Add support for cljc files #1096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@djblue thanks for the PR! This seems like it may be all that's required -- for some reason I had it in my head that there might be more complications around data readers, but that may not be so. I do not think this fixes #668 though. That ticket is referring to loading full Clojure libs from |
|
@chrisrink10, I updated the CHANGELOG 👍 |
Looks great. I also edited the PR description to change the ticket number there, but otherwise LGTM. Thanks for the submission! |
chrisrink10
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1097
I'm not sure if this is the extent of changes that need to occur, but I've been using these changes locally to start porting portal and it's been working for me.